fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27516 )
Change subject: fixup: gsm48_make_ho_cmd(): optionally add Synchronization
Indication IE
......................................................................
fixup: gsm48_make_ho_cmd(): optionally add Synchronization Indication IE
This was overlooked during the code review. GCC does not complain
because internally both 'enum handover_scope' and 'bool' are
interpreted as 'int'. Found this while running my WIP testcase
TC_srvcc_eutran_to_geran_a5_3. This change makes it pass.
Related: SYS#5838
Fixes: I4e5b1163a71443d706f14ce4bfd5c2294c320432
Change-Id: I807fd4a0e700e54c67ca3547d9c0c1b442dd1c54
(cherry picked from commit 7c14a12a786b4a297e79a6cf4a84d84393344b54)
---
M src/osmo-bsc/handover_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c
index edb50fc..8240c38 100644
--- a/src/osmo-bsc/handover_fsm.c
+++ b/src/osmo-bsc/handover_fsm.c
@@ -1199,7 +1199,7 @@
struct handover *ho = &conn->ho;
struct msgb *rr_ho_cmd = gsm48_make_ho_cmd(ho->new_lchan,
- ho->async, ho->scope,
+ ho->scope, ho->async,
ho->new_lchan->ms_power,
ho->ho_ref);
if (!rr_ho_cmd) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27516
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: 2021q4
Gerrit-Change-Id: I807fd4a0e700e54c67ca3547d9c0c1b442dd1c54
Gerrit-Change-Number: 27516
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
