pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmocore/+/27532 )


Change subject: gsm0808: Fix decoding of IE GSM0808_IE_LCS_CLIENT_TYPE
......................................................................

gsm0808: Fix decoding of IE GSM0808_IE_LCS_CLIENT_TYPE

Change-Id: I7acafdefd105e330c466df2e17e884327651e348
---
M src/gsm/gsm0808.c
M tests/gsm0808/gsm0808_test.c
2 files changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/27532/1

diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 7013d8d..27ea47b 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -1525,6 +1525,7 @@
                [GSM0808_IE_LOCATION_ESTIMATE]          = { TLV_TYPE_TLV },
                [GSM0808_IE_POSITIONING_DATA]           = { TLV_TYPE_TLV },
                [GSM0808_IE_LCS_CAUSE]                  = { TLV_TYPE_TLV },
+               [GSM0808_IE_LCS_CLIENT_TYPE]            = { TLV_TYPE_TLV },
                [GSM0808_IE_APDU]                       = { TLV_TYPE_TLV },
                [GSM0808_IE_NETWORK_ELEMENT_IDENTITY]   = { TLV_TYPE_TLV },
                [GSM0808_IE_GPS_ASSISTANCE_DATA]        = { TLV_TYPE_TLV },
diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c
index abf6b5d..6ed1941 100644
--- a/tests/gsm0808/gsm0808_test.c
+++ b/tests/gsm0808/gsm0808_test.c
@@ -485,7 +485,7 @@
        printf("Testing decoding Perform Location Report SYS#5891\n");

        rc = tlv_parse(&tp, gsm0808_att_tlvdef(), hex+1, sizeof(hex)-1, 0, 0);
-       OSMO_ASSERT(rc < 0);
+       OSMO_ASSERT(rc == 5);
 }

 static void test_create_ass()

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27532
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7acafdefd105e330c466df2e17e884327651e348
Gerrit-Change-Number: 27532
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-MessageType: newchange

Reply via email to