pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/27537 )


Change subject: system_information: Always send ext_info in SI13
......................................................................

system_information: Always send ext_info in SI13

Values in ext_info are modified in several places, so it's difficult
validating whether we deviate from default. Let's always send it so that
we always have a clear view on what the MS uses.

This fixes a bug where paging_coordination or ccn_active would not be
announced if GPRS was not enabled.

Related: SYS#5894
Change-Id: If96de3e0d77503cf6344dfbc611f9260ac3281aa
---
M src/osmo-bsc/system_information.c
1 file changed, 2 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/37/27537/1

diff --git a/src/osmo-bsc/system_information.c 
b/src/osmo-bsc/system_information.c
index 27c60a0..79008b5 100644
--- a/src/osmo-bsc/system_information.c
+++ b/src/osmo-bsc/system_information.c
@@ -1204,14 +1204,14 @@
                .drx_timer_max  = 3,
                .bs_cv_max      = 15,
                .ctrl_ack_type_use_block = true,
-               .ext_info_present = 0,
+               .ext_info_present = true,
                .ext_info = {
                        .egprs_supported = 0,           /* overridden in 
gsm_generate_si() */
                        .use_egprs_p_ch_req = 0,        /* overridden in 
generate_si13() */
                        .bep_period = 5,
                        .pfc_supported = 0,
                        .dtm_supported = 0,
-                       .bss_paging_coordination = 0,
+                       .bss_paging_coordination = 0, /* overriden in 
generate_si13() */
                        .ccn_active = false,
                },
        },
@@ -1305,7 +1305,6 @@
                si13_default.cell_opts.ext_info.egprs_supported = 1;
                /* fallthrough */
        case BTS_GPRS_GPRS:
-               si13_default.cell_opts.ext_info_present = 1;
                si_info.gprs_ind.present = 1;
                break;
        case BTS_GPRS_NONE:

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27537
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If96de3e0d77503cf6344dfbc611f9260ac3281aa
Gerrit-Change-Number: 27537
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-MessageType: newchange

Reply via email to