pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27537 )
Change subject: SI13: Always send ext_info
......................................................................
SI13: Always send ext_info
Values in ext_info are modified in several places, so it's difficult
validating whether we deviate from default. Let's always send it so that
we always have a clear view on what the MS uses.
This fixes a bug where paging_coordination or ccn_active would not be
announced if GPRS was not enabled.
Related: SYS#5894
Change-Id: If96de3e0d77503cf6344dfbc611f9260ac3281aa
---
M src/osmo-bsc/system_information.c
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/osmo-bsc/system_information.c
b/src/osmo-bsc/system_information.c
index 5541d7b..a6e1e1c 100644
--- a/src/osmo-bsc/system_information.c
+++ b/src/osmo-bsc/system_information.c
@@ -1208,15 +1208,15 @@
.drx_timer_max = 3,
.bs_cv_max = 15,
.ctrl_ack_type_use_block = true,
- .ext_info_present = 0,
+ .ext_info_present = true,
.ext_info = {
.egprs_supported = 0, /* overridden in
gsm_generate_si() */
.use_egprs_p_ch_req = 0, /* overridden in
generate_si13() */
.bep_period = 5,
.pfc_supported = 0,
.dtm_supported = 0,
- .bss_paging_coordination = 0,
- .ccn_active = false,
+ .bss_paging_coordination = 0, /* overridden in
generate_si13() */
+ .ccn_active = false, /* overridden in
generate_si13() */
},
},
.pwr_ctrl_pars = {
@@ -1309,7 +1309,6 @@
si13_default.cell_opts.ext_info.egprs_supported = 1;
/* fallthrough */
case BTS_GPRS_GPRS:
- si13_default.cell_opts.ext_info_present = 1;
si_info.gprs_ind.present = 1;
break;
case BTS_GPRS_NONE:
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27537
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If96de3e0d77503cf6344dfbc611f9260ac3281aa
Gerrit-Change-Number: 27537
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
