pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27539 )
Change subject: SI13: Avoid enabling use_egprs_p_ch_req if egprs not supported
......................................................................
SI13: Avoid enabling use_egprs_p_ch_req if egprs not supported
It makes no sense to enable that field if the ext_info.egprs_supported
field marks EGPRS as disabled.
>From TS 44.060 11.2.5a:
"""
This message may be sent by an EGPRS capable mobile station
*in a cell supporting EGPRS* and where the EGPRS_PACKET_CHANNEL_REQUEST
parameter indicates that this message shall be used.
"""
Related: SYS#5891
Change-Id: I5ac173116f8681d7340b75b2baff110158fab9fd
---
M src/osmo-bsc/system_information.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/src/osmo-bsc/system_information.c
b/src/osmo-bsc/system_information.c
index 9aae7bd..45f9860 100644
--- a/src/osmo-bsc/system_information.c
+++ b/src/osmo-bsc/system_information.c
@@ -1256,7 +1256,7 @@
si13_default.bcch_change_mark = bts->bcch_change_mark;
/* Whether EGPRS capable MSs shall use EGPRS PACKET CHANNEL REQUEST */
- if (bts->gprs.egprs_pkt_chan_request)
+ if (bts->gprs.egprs_pkt_chan_request &&
si13_default.cell_opts.ext_info.egprs_supported)
si13_default.cell_opts.ext_info.use_egprs_p_ch_req = 1;
else
si13_default.cell_opts.ext_info.use_egprs_p_ch_req = 0;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27539
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5ac173116f8681d7340b75b2baff110158fab9fd
Gerrit-Change-Number: 27539
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
