laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27536 )

Change subject: gen_links.sh.inc: Fix globbing writing '*.ttcn' to */.gitignore
......................................................................

gen_links.sh.inc: Fix globbing writing '*.ttcn' to */.gitignore

This was the case under ggsn_tests, which in turn prevents search text
tools like "ag" to find stuff in .ttcn files (because it skips code in
.gitignore).

Change-Id: Iaef3cfd5ae29db352046664ab4949b037ca80307
---
M gen_links.sh.inc
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/gen_links.sh.inc b/gen_links.sh.inc
index 539b398..c21bcd6 100644
--- a/gen_links.sh.inc
+++ b/gen_links.sh.inc
@@ -36,6 +36,8 @@
 }

 ignore_pp_results() {
+       # Avoid using the pattern itself if no file is found in globbing below:
+       shopt -s nullglob
        for pp in *.ttcnpp; do
                ttcn_file="$(echo $pp | sed 's/pp$//')"
                echo "$ttcn_file" >> .gitignore

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27536
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iaef3cfd5ae29db352046664ab4949b037ca80307
Gerrit-Change-Number: 27536
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-MessageType: merged

Reply via email to