Patch Set 15: (1 comment)
https://gerrit.osmocom.org/#/c/4334/15/src/osmo-bsc/osmo_bsc_mgcp.c File src/osmo-bsc/osmo_bsc_mgcp.c: Line 1012: return NULL; One general high-level comment. All software will fail. Put yourself into the mindset it is 36C3, it is late, you are tired and handover/assignment is failing. All you got is the log file (and maybe a PCAP). From the 100 hundred concurrent calls some fail. Is MGW_%d enough information to identify the trunk? Does it help you to identify the IMSI so you can find the packets in the PCAP file? Would you have significant information to build a mental model of what happens? And I picked the line as it represents a silent failure (Unlikely it will be ever returning NULL here though). -- To view, visit https://gerrit.osmocom.org/4334 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2882b7ca31a3219c676986e85045fa08a425d7a Gerrit-PatchSet: 15 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
