Review at https://gerrit.osmocom.org/4774
fix segfault: DLCX for unknown endpoint: dont try to log NULL endpoint
Change-Id: Ib127fd81a2d68f51c470ff77ef0822bdb4829de4
---
M src/libosmo-mgcp/mgcp_protocol.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/74/4774/1
diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c
index 8c6bd6e..9e04e50 100644
--- a/src/libosmo-mgcp/mgcp_protocol.c
+++ b/src/libosmo-mgcp/mgcp_protocol.c
@@ -853,12 +853,12 @@
struct mgcp_conn_rtp *conn = NULL;
uint32_t conn_id;
+ if (p->found != 0)
+ return create_err_response(NULL, error_code, "DLCX", p->trans);
+
LOGP(DLMGCP, LOGL_NOTICE,
"DLCX: endpoint:%x deleting connection ...\n",
ENDPOINT_NUMBER(endp));
-
- if (p->found != 0)
- return create_err_response(NULL, error_code, "DLCX", p->trans);
if (llist_count(&endp->conns) <= 0) {
LOGP(DLMGCP, LOGL_ERROR,
--
To view, visit https://gerrit.osmocom.org/4774
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib127fd81a2d68f51c470ff77ef0822bdb4829de4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <[email protected]>
