Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602 )
Change subject: ran emulation: allow multiple reset attempts ...................................................................... Patch Set 1: Code-Review-1 (3 comments) Patchset: PS1: CR-1 due to missing 'mp_' prefix. File library/RAN_Emulation.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602/comment/4ea2ef22_7356dd63 PS1, Line 526: while (attempts > 0) { > This is usually implemented in TTCN3 by means of "repeat;" keyword in the alt. IMO, the loop approach is easier to read. Not only you would need to 'repeat', but also restart the timer and send the ts_BSSMAP_Reset again in the timeout altstep. But personally I would rather use 'for' here, it's a bit shorter: for (var integer i := 0; i < g_ran_ops.bssap_reset_retries; i := i + 1) { ... } Not critical, just a matter of preferences. You can keep this code as is. File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602/comment/4f7665eb_dd389e87 PS1, Line 143: bssap_reset_retries All module parameters star with 'mp_', please align the naming. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9f6db2a24e984eef31e76f9d42a80eb6a1bb6928 Gerrit-Change-Number: 27602 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 30 Mar 2022 13:50:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
