Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 )

Change subject: tcpdump capture script: check permissions to fix running in a 
netns
......................................................................


Patch Set 1:

(1 comment)

File ttcn3-tcpdump-start.sh:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604/comment/d217d8ea_b052690a
PS1, Line 48:   getpcaps doesntmatter 2>&1 | grep -e cap_net_admin | grep -q -e 
cap_net_raw
> from the same libcap2-bin package as the setcap command in the line above.
Oh pcap here is "process capability". This is quite confusing since the code is 
doing stuff with pcaps ;)

And what about this "doesntmatter" ? According to man getpcaps seems to expect 
a pid there instead?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I75f7af6cc67e96ffb7b002591f7f7d1da9b5a51d
Gerrit-Change-Number: 27604
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: Hoernchen <[email protected]>
Gerrit-Comment-Date: Wed, 30 Mar 2022 14:27:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to