Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/27646 )

Change subject: jenkins: Validate gsm 08.58 IEs are added to tlv_definition
......................................................................


Patch Set 3:

(2 comments)

File include/osmocom/gsm/protocol/gsm_08_58.h:

https://gerrit.osmocom.org/c/libosmocore/+/27646/comment/117fb420_9ccd82f6
PS3, Line 388:  RSL_IE_IPAC_RTP_PAYLOAD2 = 0xfc,
Why changing spacing in this patch?


File src/gsm/rsl.c:

https://gerrit.osmocom.org/c/libosmocore/+/27646/comment/56d016ce_cf6bbed0
PS3, Line 128:          [RSL_IE_IPAC_SRTP_CONFIG]       = { TLV_TYPE_TLV },
This looks unrelated, please submit a separate change.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27646
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id8a679ca43eb0fcc4882780e9a95ec21c7f51972
Gerrit-Change-Number: 27646
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 04 Apr 2022 22:02:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to