Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27654 )

Change subject: Diameter_Templates.ttcn: Avoid sending AuthAppId Relay in CEA
......................................................................


Patch Set 1: Code-Review+2

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27654/comment/14ab4bfa_51622a66
PS1, Line 7: Relay
This is the key word here.


Patchset:

PS1:
The comments below helped me to understand the patch better while doing review.


File library/DIAMETER_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27654/comment/23b0b8a2_34433273
PS1, Line 883: ts_AVP_AuthAppId
Here I see that the ts_AVP_AuthAppId was listed twice, so we're including only 
one now with the given auth_app_id value.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27654
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0a9daf094f4c27c0b4de5581ddd56feced8e5732
Gerrit-Change-Number: 27654
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 07 Apr 2022 08:33:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to