fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/27696 )
Change subject: power_ctrl_params_def_reset(): set .ctrl_interval for both UL/DL
......................................................................
power_ctrl_params_def_reset(): set .ctrl_interval for both UL/DL
For the sake of consistency and code readability, initialize the
power loop control interval (P_Con_INTERVAL) for both Uplink and
Downlink directions in the same function.
Change-Id: If7c804e51eb104d9fe73294a3867ab3b551d83c3
---
M src/common/power_control.c
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/96/27696/1
diff --git a/src/common/power_control.c b/src/common/power_control.c
index 42d9d07..0db5378 100644
--- a/src/common/power_control.c
+++ b/src/common/power_control.c
@@ -404,9 +404,6 @@
/* Default MS/BS Power Control parameters (see 3GPP TS 45.008, table A.1) */
const struct gsm_power_ctrl_params power_ctrl_params_def = {
-
- .ctrl_interval = 1, /* Trigger loop every second SACCH block. TS 45.008
sec 4.7.1 */
-
/* Power increasing/reducing step size (optimal defaults) */
.inc_step_size_db = 4, /* quickly increase MS/BS power */
.red_step_size_db = 2, /* slowly decrease MS/BS power */
@@ -569,7 +566,10 @@
void power_ctrl_params_def_reset(struct gsm_power_ctrl_params *params, bool
is_bs_pwr)
{
*params = power_ctrl_params_def;
+
+ /* Trigger loop every N-th SACCH block. See 3GPP TS 45.008 section
4.7.1. */
if (!is_bs_pwr)
- /* Trigger loop every fourth SACCH block (1.92s). TS 45.008 sec
4.7.1: */
- params->ctrl_interval = 2;
+ params->ctrl_interval = 2; /* N=4 (1.92s) */
+ else
+ params->ctrl_interval = 1; /* N=2 (0.960) */
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27696
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If7c804e51eb104d9fe73294a3867ab3b551d83c3
Gerrit-Change-Number: 27696
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-MessageType: newchange
