Attention is currently required from: neels.
iedemam has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/27081 )

Change subject: stats: new trackers for lchan life duration
......................................................................


Patch Set 20:

(3 comments)

File src/osmo-bsc/bts_trx_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/3fad8e64_c0f35692
PS19, Line 576:                         VTY_NEWLINE);
> this will print nonsense values for lchan types other than SDCCH and TCH, 
> unless we remove those con […]
Done


File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/b5d3897c_8eafe655
PS19, Line 225:         if (lchan->active_cc.cfg.rate_ctr) {
> let's remove this condition: always (re)start the activity time_cc, also for 
> lchan types other than  […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/7b7bef8f_d8649b0d
PS19, Line 560:         if (lchan->active_cc.cfg.rate_ctr) {
> remove this condition, always set the flag. Does not matter wheter a rate_ctr 
> is set.
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347
Gerrit-Change-Number: 27081
Gerrit-PatchSet: 20
Gerrit-Owner: iedemam <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Mon, 11 Apr 2022 12:19:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <[email protected]>
Gerrit-MessageType: comment

Reply via email to