pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-uecups/+/27737 )
Change subject: main: Remove duplicate call to child_terminated()
......................................................................
main: Remove duplicate call to child_terminated()
The same pid will be handled below tyhrough waitpid. This can be seen
when running PGW_Tests:
"""
20220411134309656 DUECUPS main.c:343 SIGCHLD receive from pid 24; status=0
20220411134309656 DUECUPS main.c:95 r=172.18.18.202:9999<->l=172.18.18.20:4268:
JSON Tx '{"program_term_ind": {"exit_code": 0, "pid": 24}}'
20220411134309656 DUECUPS main.c:343 SIGCHLD receive from pid 24; status=0
"""
Change-Id: I348b91097fe9bf78b2c7e33d4f3eaf316618068e
---
M daemon/main.c
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
daniel: Looks good to me, approved
diff --git a/daemon/main.c b/daemon/main.c
index 39d60e6..328d074 100644
--- a/daemon/main.c
+++ b/daemon/main.c
@@ -367,8 +367,6 @@
OSMO_ASSERT(fdsi->ssi_signo == SIGCHLD);
- child_terminated(d, fdsi->ssi_pid, fdsi->ssi_status);
-
/* it is known that classic signals coalesce: If you get multiple
signals of the
* same type before a process is scheduled, the subsequent signals are
dropped. This
* makes sense for SIGINT or something like this, but for SIGCHLD
carrying the PID of
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/27737
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I348b91097fe9bf78b2c7e33d4f3eaf316618068e
Gerrit-Change-Number: 27737
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
