Patch Set 1: The rationale in here is indeed to make the code more reachable for newcomers, as well as more organized for people like me who works a lot with this code.
SuiteRun in suite.py is already quite big, and having the Test class in there make it unnecessarily more big, and makes it difficult to find stuff. At the same time, having a test.py which does actually not contain the Test class but other stuff, makes it even more confusing. -- To view, visit https://gerrit.osmocom.org/4764 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c8d67f598466ba52a4827ff77027b9eae85929a Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: No
