laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-e1d/+/27840 )
Change subject: e1oip: Rename e1oip:overflow to e1oip:e1o_overflow
......................................................................
e1oip: Rename e1oip:overflow to e1oip:e1o_overflow
This indicates that this is counting an E1-originated overflow of the
OCTOI transmit FIFO, which should never happen unless your system is too
slow to periodically schedule the related timers in the code.
Change-Id: I0af6a2847c8356b011bcff5cc4f5d909c574ea21
---
M src/octoi/e1oip.c
M src/octoi/e1oip.h
M src/octoi/octoi.c
3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/40/27840/1
diff --git a/src/octoi/e1oip.c b/src/octoi/e1oip.c
index 38a22b5..b767ba7 100644
--- a/src/octoi/e1oip.c
+++ b/src/octoi/e1oip.c
@@ -45,8 +45,8 @@
static const struct rate_ctr_desc iline_ctr_description[] = {
[LINE_CTR_E1oIP_UNDERRUN] = { "e1oip:underrun", "Frames underrun /
slipped in IP->E1 direction"},
- [LINE_CTR_E1oIP_SUBSTITUTED] = { "e1oip:substituted", "Frames
substituted in IP->E1 direction"},
- [LINE_CTR_E1oIP_OVERFLOW] = { "e1oip:overflow", "Frames overflowed in
IP->E1 direction"},
+ [LINE_CTR_E1oIP_SUBSTITUTED] = { "e1oip:substituted", "Frames
substituted in E1->IP direction"},
+ [LINE_CTR_E1oIP_E1O_OVERFLOW] = { "e1oip:e1o_overflow", "Frames
overflowed in IP->E1 direction"},
[LINE_CTR_E1oIP_RX_OUT_OF_ORDER] = { "e1oip:rx:pkt_out_of_order",
"Packets out-of-order in IP->E1 direction"},
[LINE_CTR_E1oIP_RX_OUT_OF_WIN] = { "e1oip:rx:pkt_out_of_win", "Packets
out-of-rx-window in IP->E1 direction"},
};
diff --git a/src/octoi/e1oip.h b/src/octoi/e1oip.h
index c992622..65ae473 100644
--- a/src/octoi/e1oip.h
+++ b/src/octoi/e1oip.h
@@ -16,7 +16,7 @@
enum e1oip_line_ctr {
LINE_CTR_E1oIP_UNDERRUN,
LINE_CTR_E1oIP_SUBSTITUTED,
- LINE_CTR_E1oIP_OVERFLOW,
+ LINE_CTR_E1oIP_E1O_OVERFLOW,
LINE_CTR_E1oIP_RX_OUT_OF_ORDER,
LINE_CTR_E1oIP_RX_OUT_OF_WIN,
};
diff --git a/src/octoi/octoi.c b/src/octoi/octoi.c
index 5f4c2f9..8d82092 100644
--- a/src/octoi/octoi.c
+++ b/src/octoi/octoi.c
@@ -101,7 +101,7 @@
rc = frame_fifo_in_multi(&iline->e1o.fifo, buf, ftr);
if (rc < ftr)
- iline_ctr_add(iline, LINE_CTR_E1oIP_OVERFLOW, ftr - rc);
+ iline_ctr_add(iline, LINE_CTR_E1oIP_E1O_OVERFLOW, ftr - rc);
iline_stat_set(iline, LINE_STAT_E1oIP_E1O_FIFO,
frame_fifo_frames(&iline->e1o.fifo));
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27840
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I0af6a2847c8356b011bcff5cc4f5d909c574ea21
Gerrit-Change-Number: 27840
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-MessageType: newchange
