Attention is currently required from: manawyrm, roox, laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27841 )
Change subject: e1oip: Add rate_ctr for IP->E1 RIFO overflows ...................................................................... Patch Set 6: (1 comment) File src/octoi/e1oip.c: https://gerrit.osmocom.org/c/osmo-e1d/+/27841/comment/a91fe0cf_59ae5c68 PS2, Line 255: rc = frame_rifo_in(&iline->e1t.rifo, frame_buf, fn32+i); > so what kind of naming would you prefer? e1oip:e1t_out_of_ragge? > out_of_window? I somehow like the […] Yeah, I think it's too much of a misnomer because in the stat in case of a desync we'll end up with 8000/s UNDERFLOW _and_ 8000/s OVERFLOW, that's just weird. I think DISCARDED maybe ? but I'm fine with "out of range". Or we can also have the rifo_in differentiate between too_old and too_new and have two counters, but that might be overkill. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ie0e8bb2f5d2ae4256952f6bf69e514d5c2627a76 Gerrit-Change-Number: 27841 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <[email protected]> Gerrit-Reviewer: roox <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-Attention: manawyrm <[email protected]> Gerrit-Attention: roox <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Wed, 20 Apr 2022 14:16:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: tnt <[email protected]> Gerrit-MessageType: comment
