Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27818 )
Change subject: lchan_fsm: Ignore other SAPIs of RLL_REL_IND for SAPI=0 is received ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27818/comment/ba6459c2_b82d3b5d PS1, Line 1210: * seem to send a RLL_REL_IND for SAPI=3 if there was already one for SAPI=0 */ > Some of my notes made while trying to understand what's happening here. […] Damn, Gerrit ate the most important of my comment: By checking !(link_id & 0xc0) we actually make sure that this is not SACCH. So the comment "but not if the link_id contains a TCH flag" is wrong, there is simply no such thing like "a TCH flag". -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27818 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia9caa5b0a5efdc459d94621367376927959a6e65 Gerrit-Change-Number: 27818 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 20 Apr 2022 15:34:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
