Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853 )
Change subject: pgw: Initial Gy support ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853/comment/204b0fc5_da1416f5 PS2, Line 9: Change-Id: I04cf78cb4bc73de59f803c01208a7ef9056cb14f Related issue would be very useful for timesheet, I guess SYS#5276 File pgw/PGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853/comment/ba558b13_9e485604 PS2, Line 320: Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, > Let's keep setverdict() separate from f_shutdown(), so that there is no need > to use log2str(). Why would it be important not to use log2str here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27853 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04cf78cb4bc73de59f803c01208a7ef9056cb14f Gerrit-Change-Number: 27853 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 22 Apr 2022 09:03:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
