laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-remsim/+/28055 )


Change subject: bankd: Log more clearly if we fail to open a PC/SC reader
......................................................................

bankd: Log more clearly if we fail to open a PC/SC reader

Related: SYS#5950
Change-Id: I424f585a8a37f21806898e59e350201119645a21
---
M src/bankd/bankd_pcsc.c
1 file changed, 7 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/55/28055/1

diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c
index d7bb39c..ee01c93 100644
--- a/src/bankd/bankd_pcsc.c
+++ b/src/bankd/bankd_pcsc.c
@@ -237,13 +237,19 @@
                                          &dwActiveProtocol);
                        if (rc == SCARD_S_SUCCESS)
                                result = 0;
-                       else
+                       else {
                                LOGW_PCSC_ERROR(worker, rc, "SCardConnect");
+                               goto out_readerfree;
+                       }
                        break;
                }
                p += strlen(p) + 1;
        }

+       if (result < 0)
+               LOGW(worker, "Error: Cannot find PC/SC reader/slot matching 
using regex '%s'\n", worker->reader.name);
+
+out_readerfree:
        SCardFreeMemory(worker->reader.pcsc.hContext, mszReaders);

 out_regfree:

--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28055
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I424f585a8a37f21806898e59e350201119645a21
Gerrit-Change-Number: 28055
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-MessageType: newchange

Reply via email to