Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28063 )
Change subject: input/ipaccess: Don't start zero-ms timer on every write ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/28063/comment/91b3ebb5_763f36bc PS1, Line 535: } I think with this change you are leaving write enabled even if there's no more stuff in the queue to send for this TS. So that means poll will trigger again and end up in the path of line 496 (e1inp_tx_ts() returning NULL). So ideally, in this line there would be an: else { if (list_for_this_ts_is_empty()) osmo_fd_write_disable(bfd); } This can of course be seen as an extra optimization, done in a different patch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28063 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9c379364e7e6afce35fc6316392b5b33748980f7 Gerrit-Change-Number: 28063 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Sun, 08 May 2022 18:14:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
