Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28059 )
Change subject: paging: Implement upper bound of 60s for dynamic T3113 ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: Somewhat unrelated, but tests/paging/paging_test.ok is hard to review as it has so many lines. Maybe it makes sense to change the test in another patch so it outputs something less verbose? File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28059/comment/f3283d15_bf9e44e5 PS3, Line 394: to, estimated_to); I think it's not obvious why in most cases you would have "expires in 5 seconds (estimated 5)". Both times are estimates, but "to" is cut off at 60 seconds. So maybe log a separate message in case the bound is not hit, which only has the number once? (And maybe the message could be reworded to make it more clear in case the upper bound is reached? But I don't have a good suggestion so maybe just leave as is.) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28059 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib8228f8485527d34794048a9927e62b6ec8d802a Gerrit-Change-Number: 28059 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 10 May 2022 09:19:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
