Attention is currently required from: pespin.
osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/28079 )

Change subject: acc: Simplify start/stop by using new signal S_NM_RUNNING_CHG
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Patchset:

PS1:
nice how this is less complex now


File src/osmo-bsc/acc.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/28079/comment/ba30917e_a32d0827
PS1, Line 433:  }
this block is the same as in nm_sig_cb. maybe create a function for getting the 
trx from nsd?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28079
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2e09bcb18a6c3bb2e88bba98579fb4854a6b0699
Gerrit-Change-Number: 28079
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 10 May 2022 10:06:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to