fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/28082 )
Change subject: tests/meas: improve logging in test_ts45008_83_is_sub_single()
......................................................................
tests/meas: improve logging in test_ts45008_83_is_sub_single()
* Print unexpected TDMA FNs, each on a separate new line.
* Do not abort() on mismatch, keep running.
Change-Id: I32c104b139f32a39c8347de19de6ad7caec811de
Related: SYS#5853
---
M tests/meas/meas_test.c
1 file changed, 3 insertions(+), 8 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
diff --git a/tests/meas/meas_test.c b/tests/meas/meas_test.c
index 9494495..32f0e7a 100644
--- a/tests/meas/meas_test.c
+++ b/tests/meas/meas_test.c
@@ -464,8 +464,7 @@
lchan->tch_mode = GSM48_CMODE_SPEECH_V1;
}
- printf(" TS=%u ", ts);
- printf("SS=%u", ss);
+ printf(" TS=%u SS=%u\n", ts, ss);
/* Walk trough the first 100 intervals and check for unexpected
* results (false positive and false negative) */
@@ -474,19 +473,15 @@
if (rc) {
if (!test_ts45008_83_is_sub_is_sacch(i)
&& !test_ts45008_83_is_sub_is_sub(i, ss)) {
- printf("==> Unexpected SUB frame at fn=%u", i);
- OSMO_ASSERT(false);
+ printf(" ==> Unexpected SUB frame at fn=%u\n",
i);
}
} else {
if (test_ts45008_83_is_sub_is_sacch(i)
&& test_ts45008_83_is_sub_is_sub(i, ss)) {
- printf("==> Unexpected non-SUB frame at fn=%u",
- i);
- OSMO_ASSERT(false);
+ printf(" ==> Unexpected non-SUB frame at
fn=%u\n", i);
}
}
}
- printf("\n");
}
static void test_ts45008_83_is_sub(void)
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/28082
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I32c104b139f32a39c8347de19de6ad7caec811de
Gerrit-Change-Number: 28082
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
