Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28091 )

Change subject: ggsn: Append ChargingCharacteristics IE to CreatePdpCtxReq
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

File library/GTP_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28091/comment/158c7dc0_5998d3bb
PS1, Line 128: template
> Field 'chargingChar' is not 'optional', so please add '(present)'. […]
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28091/comment/624bb3aa_57db09fa
PS1, Line 399: ts_ChargingCharacteristics
> Indeed, sorry I started passing the whole ChargingCharacteristics_GTPC and 
> later found it made more  […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28091
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia0f74041d2107afeaa36b94e33474370b7b07c0e
Gerrit-Change-Number: 28091
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 13 May 2022 12:10:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to