laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/28129 )
Change subject: Revert "osmo-bts-trx: rx_tchf_fn(): do not treat AFS_SID_UPDATE
as SUB frame"
......................................................................
Revert "osmo-bts-trx: rx_tchf_fn(): do not treat AFS_SID_UPDATE as SUB frame"
This reverts commit 1f9fbd881602f20f5d83b94f2332c18c19b680e0, which
was a workaround rather than a proper fix. The root problem has
been fixed in libosmocoding [1], so ~50% BER is not the case for
AFS_SID_UPDATE frames anymore.
Related: I813081a4c0865958eee2496fe251ae17235ac842 (libosmocore.git)
Change-Id: Iebe139632daf1d1f72e39fe9d1497059f68625b9
---
M src/osmo-bts-trx/sched_lchan_tchf.c
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c
b/src/osmo-bts-trx/sched_lchan_tchf.c
index 067e31a..6a90327 100644
--- a/src/osmo-bts-trx/sched_lchan_tchf.c
+++ b/src/osmo-bts-trx/sched_lchan_tchf.c
@@ -171,11 +171,7 @@
"Received AMR DTX frame (rc=%d, BER %d/%d):
%s\n",
rc, n_errors, n_bits_total,
gsm0503_amr_dtx_frame_name(chan_state->amr_last_dtx));
- /* ... except AFS_SID_UPDATE, which is in fact a
precursor of
- * the actual SID UPDATE frame (AFS_SID_UPDATE_CN) and
only
- * used internally by gsm0503_tch_afs_decode_dtx() */
- if (chan_state->amr_last_dtx != AFS_SID_UPDATE)
- is_sub = 1;
+ is_sub = 1;
}
/* The occurrence of the following frames indicates that we
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/28129
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iebe139632daf1d1f72e39fe9d1497059f68625b9
Gerrit-Change-Number: 28129
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
