Attention is currently required from: iedemam, neels, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28165 )
Change subject: stats: new trackers for lchan life duration (v2)
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Hi all, […]
did you do some testing / profiling under load comparing old vs. new approach?
The poll / syscall load for sure is no longer a concern. If you're worried
that doing everything in one timer for all the BTSs of a BSC, it might be
interesting to do some probing how long it takes between function entry and
function exit of the new per-second timer function.
Something like the followign bpftrace snippet would print you a histogram of
the duration between entry and exit of the function (update interval every 10s):
---
/* time spent in bsc_store_bts_lchan_duration */
uprobe:/usr/local/bin/osmo-bsc:bsc_store_bts_lchan_durations {
@timer_start = nsecs;
}
uretprobe:/usr/local/bin/osmo-bsc:bsc_store_bts_lchan_durations {
$duration = (nsecs - @timer_start)/1000000;
@bsc_store_bts_lchan_duration= hist($duration);
}
/* report every 10s */
interval:s:10 {
printf("========================================================== ");
time("%Y-%m-%d %H:%M:%S\n");
print(@bsc_store_bts_lchan_duration);
}
---
(untested, as I don't have a osmo-bsc with that new function/symbol).
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28165
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie3771233ecbd4bc24a24fb22c1064a18e7b8b2b0
Gerrit-Change-Number: 28165
Gerrit-PatchSet: 1
Gerrit-Owner: iedemam <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: iedemam <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 19 May 2022 19:44:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: iedemam <[email protected]>
Gerrit-MessageType: comment
