Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/28176 )

Change subject: coding: add gsm0503_detect_a[fh]s_dtx_frame2()
......................................................................


Patch Set 2:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/28176/comment/f828a022_8c4071cf
PS2, Line 14: Converting to hard-bits is not really needed.
> Initially I was planning to simplify the code to calculate a sum of all 
> soft-bits, so that we could  […]
Done


File src/coding/gsm0503_amr_dtx.c:

https://gerrit.osmocom.org/c/libosmocore/+/28176/comment/384bd78e_cbc86630
PS2, Line 279:  *  \param[in] sbits input soft-bits (456 bit).
> new parameter mode_id is not documented
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28176
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibcac395f800bb64150c97fcdaca3523ecfc5fcee
Gerrit-Change-Number: 28176
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 26 May 2022 09:40:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to