pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28131 )
Change subject: stp: Fix sporadic failure in TC_ipa_to_m3ua_ni
......................................................................
stp: Fix sporadic failure in TC_ipa_to_m3ua_ni
It was spotted that from time to time the test set NI international
instead of national. This is presumable due to a race condition between
VTY and messages being received and forwarded.
Let's delay resetting the VTY config after the message is recieved, to
avoid the race conditions between them.
Change-Id: I3ef08447d2e36b6948d3db4ec9d1459beebc9384
---
M stp/STP_Tests.ttcn
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
daniel: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/stp/STP_Tests.ttcn b/stp/STP_Tests.ttcn
index ac45b1d..48214be 100644
--- a/stp/STP_Tests.ttcn
+++ b/stp/STP_Tests.ttcn
@@ -144,14 +144,13 @@
var octetstring sccp_enc := enc_PDU_SCCP(sccp);
f_vty_config2(VTY, {"cs7 instance 0"}, "network-indicator national");
f_IPA_send(3, sccp_enc);
- f_vty_config2(VTY, {"cs7 instance 0"}, "network-indicator
international");
/* expect to receive it via M3UA */
var template (present) M3UA_Protocol_Data rx_pd;
rx_pd := tr_M3UA_protocol_data(pc_sender, pc_receiver, c_M3UA_SI_SCCP,
c_M3UA_NI_NATIONAL,
'00'O, '00'O, sccp_enc);
f_M3UA_exp(0, tr_M3UA_DATA(rctx_receiver, rx_pd));
-
+ f_vty_config2(VTY, {"cs7 instance 0"}, "network-indicator
international");
f_clear_m3ua();
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28131
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3ef08447d2e36b6948d3db4ec9d1459beebc9384
Gerrit-Change-Number: 28131
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
