Attention is currently required from: dexter.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/28162 )

Change subject: pySim-shell: catch exceptions from walk() while exporting
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/28162/comment/750ca161_b9e8a458
PS2, Line 679:             except Exception as e:
Does pySim-shell support multi-line comments in a script file? If so, I would 
do:

  try:
    ...
  except e:
    ...
    import traceback
    print("'''")
    print(traceback.format_exc())
    print("'''")



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28162
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3edc250ef2a84550c5b821a72e207e4d685790a5
Gerrit-Change-Number: 28162
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Thu, 26 May 2022 20:18:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to