Attention is currently required from: fixeria.
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/28185 )

Change subject: ts_102_221: The BTLV IEs FILE SIZE and TOTAL FILE SIZE have a 
min length
......................................................................


Patch Set 2:

(1 comment)

File pySim/construct.py:

https://gerrit.osmocom.org/c/pysim/+/28185/comment/f2f6ed2c_40c8ac43
PS1, Line 244: length = length + (self.minlen - length)
> This looks weird to me, because 'length' would always be equal to 
> 'self.minlen': […]
I see now where the error is. Thanks.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28185
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ief113ce8fe3bcae2c9fb2ff4138df9ccf98d26ff
Gerrit-Change-Number: 28185
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 01 Jun 2022 16:22:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to