Attention is currently required from: neels, laforge, pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 )
Change subject: Add subscr_conn_fsm ...................................................................... Patch Set 5: (1 comment) File src/osmo-bsc-nat/bssap_conn.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/07976146_4c87bec5 PS4, Line 47: uint8_t tag = tag_order[i]; > See osmo-hnbgw, dexter did it there for RTP afair. I've looked at the osmo-hnbgw implementation, it's for ASN.1. I've updated the patch to decode each IE at a time, if it's the aoip transp layer addr, encode the new address, otherwise re-encode the original IE. Replacing the IE inside the buffer seems like a hack to me since to locate it correctly we already need to be able to parse the IEs coming before it with the tlv definition currently built against. And we can't do that reliably if there are unknown IEs and if they do not have TLV_TYPE_TLV but another format like TLV_TYPE_FIXED, TLV_TYPE_T, TLV_TYPE_TV etc. So we may end up decoding garbage and finding what looks like the aoip transp addr IE by chance. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7e491aada6f5db0eb35ef2039869c6ba07f9ca3b Gerrit-Change-Number: 27712 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Wed, 08 Jun 2022 12:23:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
