Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28245 )
Change subject: install libosmo-gtlv, libosmo-pfcp ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > my opinion is i don't mind either way. […] We already discussed some of this and I think it was already agreed we definetly didn't want to move more protocol specific libs inside libosmocore. Is libosmo-tlv used somewhere outside libosmo-pfcp internal code? If the answer is no, simply move everything inside libosmo-pfcp.git. If the answer is yes, or you plan to use it somewhere else, then I'm fine with moving libosmo-tlv as a different shared object inside libosmocore.git, but still keeping libosmo-pfcp outside of libosmocore.git. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9f4651b6bee457583aba99052dc82bbf675515e6 Gerrit-Change-Number: 28245 Gerrit-PatchSet: 3 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Wed, 08 Jun 2022 18:27:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
