Attention is currently required from: neels.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/28239 )

Change subject: implement OSMO_LOG_PFCP_MSG_SRC as va function
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1:
I don't have a strong position either way.  It's a difficult trade-off between 
bloating every caller code site (macro) and the additional runtime overhead of 
function call + varargs.



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28239
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I1713868ebb9583c67f0a4ecc9558263f6888a24d
Gerrit-Change-Number: 28239
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Fri, 10 Jun 2022 05:06:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to