Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/28250 )
Change subject: llsk: Validate received SAPI versions at startup ...................................................................... Patch Set 1: (1 comment) File include/osmocom/hnodeb/hnodeb.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/28250/comment/29b044f0_9f70b907 PS1, Line 95: uint16_t sapi_version_iuh; > might again make a nice sub-struct for llsk.sapi_version.{iuh,gtp,audio}. […] I don't think it makes much sense right now, since anyway there's already structs for most of the stuff in the in"iuh/rtp/gtp" structs at the above level. But I didn't want to put it there since this is really related to the llsk lower level internal stuff, and the other existing structs are more for high level general stuff. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/28250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I172abfee3bfadb383aa6bce6fe76306291c7cd7f Gerrit-Change-Number: 28250 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Fri, 10 Jun 2022 09:43:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
