Attention is currently required from: osmith.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnodeb/+/28251 )

Change subject: audio: Introduce SAPI v1 with unordered RFCI support
......................................................................


Patch Set 1:

(1 comment)

File src/osmo-hnodeb/llsk_audio.c:

https://gerrit.osmocom.org/c/osmo-hnodeb/+/28251/comment/6808c34a_7592e869
PS1, Line 76:           
llsk_audio_prim_size_tbl[PRIM_OP_REQUEST][HNB_AUDIO_PRIM_CONN_ESTABLISH] =
> I'm a bit surprised that this modifies a global variable. […]
Yes, one osmo-hnodeb has 1 llsk socket.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/28251
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnodeb
Gerrit-Branch: master
Gerrit-Change-Id: I860d18b80c1041bf63a1570d435e0568c0f6b01b
Gerrit-Change-Number: 28251
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Fri, 10 Jun 2022 11:31:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>
Gerrit-MessageType: comment

Reply via email to