pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28263 )
Change subject: fix segfault in error handling for mgw_fi == NULL
......................................................................
fix segfault in error handling for mgw_fi == NULL
In mgw_fsm_handle_rab_ass_resp(), a NULL mgw_fi is handled as error,
but the error handling fails to return. The function continues to
dereference mgw_fi. Add missing return.
Related: SYS#5995
Change-Id: I3e98dc3a00145ec1f71c678bbf45debfd4276237
---
M src/osmo-hnbgw/mgw_fsm.c
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c
index d90571b..b84d87e 100644
--- a/src/osmo-hnbgw/mgw_fsm.c
+++ b/src/osmo-hnbgw/mgw_fsm.c
@@ -767,6 +767,7 @@
/* Send a release request, to make sure that the MSC is aware
of the problem. */
tx_release_req(map);
+ return -1;
}
mgw_fsm_priv = map->mgw_fi->priv;
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28263
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I3e98dc3a00145ec1f71c678bbf45debfd4276237
Gerrit-Change-Number: 28263
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
