Attention is currently required from: dexter.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/28185 )

Change subject: ts_102_221: The BTLV IEs FILE SIZE and TOTAL FILE SIZE have a 
min length
......................................................................


Patch Set 9:

(1 comment)

File pySim/construct.py:

https://gerrit.osmocom.org/c/pysim/+/28185/comment/cde634f3_72ba9412
PS5, Line 241:         if nbytes < minlen:
> Done
I do not insist on using min() here, but could you please explain (or give an 
example) what's wrong with using it? What exactly behaves differently? Just 
curious.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/28185
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ief113ce8fe3bcae2c9fb2ff4138df9ccf98d26ff
Gerrit-Change-Number: 28185
Gerrit-PatchSet: 9
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Fri, 10 Jun 2022 17:08:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>
Gerrit-MessageType: comment

Reply via email to