Attention is currently required from: pespin.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/28309 )

Change subject: implement GTP tunnel mapping via netfilter
......................................................................


Patch Set 5:

(1 comment)

This change is ready for review.

Patchset:

PS5:
the build error comes from the VTY-test, from the nftables command
"add table inet osmo-upf"
happening at osmo-upf startup.

I think the reason for failure is that it requires cap_net_admin?
Could also be that the kernel is too old?

Ways to resolve:

- change osmo-upf: only dispatch "add table" the first time nftables is used.
  But i think it is a good idea for production admin to verify at startup that 
nftables is usable.
  This change would be a dumb workaround for our CI only.

- change build job:
  I guess add cap_net_admin to the binary, but i thought the build job is 
already running as root in a docker container.
  Maybe need a newer kernel??? i'll try to find out...



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28309
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d319eb4f98cd51a5999c804c4203ab0bdda650
Gerrit-Change-Number: 28309
Gerrit-PatchSet: 5
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Sun, 19 Jun 2022 12:31:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to