Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/28337 )

Change subject: separate pfcp_queue_timer_cb() in req and resp
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File src/libosmo-pfcp/pfcp_endpoint.c:

https://gerrit.osmocom.org/c/libosmo-pfcp/+/28337/comment/97bfe9b0_d58c08a9
PS1, Line 285:  } else {
You'll probably want to name the 2 timers differently (put them in a union), 
since anyway you'll want to have different timer configurations for each of the 
two.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28337
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Ic8ab71f5efd4cf669689a0b075f9a52ce66bdd5d
Gerrit-Change-Number: 28337
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Mon, 20 Jun 2022 08:57:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to