Attention is currently required from: neels, fixeria.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/28326 )

Change subject: lchan_select: prepare a list of timeslots once, iterate over it
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
I'm not really liking this new approach/path, looks like unnecessarily dropping 
performance here generating a full array each time, then iterating it. I think 
this can be probably still be done without having to generate a full list of TS 
every time a new lchan needs to be selected.
Let's merge if everyone else is happy with this, just sharing my thoughts here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28326
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7ccc56856bfd40fd7c63b7437736de60c2b516ff
Gerrit-Change-Number: 28326
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 20 Jun 2022 09:28:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to