laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-cbc/+/28499 )

Change subject: cbsp_server: Exit process gracefully if binding socket fails
......................................................................

cbsp_server: Exit process gracefully if binding socket fails

Change-Id: I6fac793aa6975cacfeffc3389167bd00864a8a08
---
M src/cbsp_server.c
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/cbsp_server.c b/src/cbsp_server.c
index b265b53..c6312dc 100644
--- a/src/cbsp_server.c
+++ b/src/cbsp_server.c
@@ -227,7 +227,11 @@
                osmo_stream_srv_link_set_addr(cbc->link, bind_ip);
        osmo_stream_srv_link_set_accept_cb(cbc->link, cbsp_cbc_accept_cb);
        rc = osmo_stream_srv_link_open(cbc->link);
-       OSMO_ASSERT(rc == 0);
+       if (rc < 0) {
+               osmo_stream_srv_link_destroy(cbc->link);
+               talloc_free(cbc);
+               return NULL;
+       }
        LOGP(DCBSP, LOGL_NOTICE, "Listening for CBSP at %s\n",
                osmo_stream_srv_link_get_sockname(cbc->link));


--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28499
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I6fac793aa6975cacfeffc3389167bd00864a8a08
Gerrit-Change-Number: 28499
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-MessageType: merged

Reply via email to