Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28520 )
Change subject: stream: assert params are not NULL in send/recv functions ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Makes sense to me, but wouldn't the functions crash anyway when one of the > parameters in questions i […] Yes, crashing is fine since it should not happen and if it happens it means the caller has some several problem, hence it's good to catch it early during develop time. That's what I encountered while extending osmo-cbc, with the problem that the crash happened when accessing the null pointer so it was no obvious at all when the sigsegv was occuring. If instead of that, an assert is hit, then it's immediatelly obvios when looking at the program's output. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28520 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie9e67396973128aba87b584be1a36e2a94dd0998 Gerrit-Change-Number: 28520 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Wed, 06 Jul 2022 11:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
