Attention is currently required from: laforge, fixeria, pespin.
osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22621 )

Change subject: TRXD: cosmetic: use attribute 'rotate' for 1 bit fields
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4:
> The actual build is running inside a debian 10 image in docker: […]
Okay looks like this patch was failing before, and you expected it to pass once 
we move away from debian 9 and have a newer python3-blockdiag version.

Well, these builds run against debian 10 now (not 11 to ensure that we can 
still build the packages for debian 10 too). Debian 10 has the same 
python3-blockdiag version 1.5.3 as debian 9, it only gets upgraded to 2.0.1 in 
debian 11 and upwards: 
https://packages.debian.org/search?suite=default&section=all&arch=any&searchon=names&keywords=python3-blockdiag

So we can't merge this yet, we would break building the package on debian 10.



--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22621
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I604cd85f79a8c21ef536840e017e8af399e935c7
Gerrit-Change-Number: 22621
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 07 Jul 2022 09:10:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to