Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28549 )
Change subject: trxcon: return prim pointer from l1sched_prim_alloc() ...................................................................... Patch Set 3: Code-Review-1 (1 comment) Patchset: PS3: well an _init() function is expected to initialize something that was provided by the caller. Now the funciton is called _alloc() which hints that is allocating something. Your commit log just mentions about the pointer return value and nothing about the rename. If the function really is allocating some memory, then the rename makes sense - but that should be mentioned. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0fa41cf55e90d191d032bca1754941cca763b03e Gerrit-Change-Number: 28549 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 11 Jul 2022 19:19:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
