Attention is currently required from: wbokslag. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28596 )
Change subject: fixed out of bounds write to pdu_sync buffer ...................................................................... Patch Set 1: (1 comment) File src/conv_enc_test.c: https://gerrit.osmocom.org/c/osmo-tetra/+/28596/comment/5c2f0aab_8a8a415f PS1, Line 338: *((uint32_t *)pdu_sync) = r; are we sure pdu_sync is always aligned and the type-cast is safe even on architectures that don't do unaligned accesses? we do have osmo_store{32,64}{le,be}() in osmocom/core/bit{32,64}gen.h -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I414bf2d61dc1cb37d30dc84b401a75b918116bbb Gerrit-Change-Number: 28596 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: wbokslag <[email protected]> Gerrit-Comment-Date: Wed, 13 Jul 2022 17:39:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
