Attention is currently required from: wbokslag, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28597 )
Change subject: moved variable declaration to prevent compiler warnings ...................................................................... Patch Set 1: (1 comment) File src/conv_enc_test.c: https://gerrit.osmocom.org/c/osmo-tetra/+/28597/comment/56976b7b_aba13520 PS1, Line 319: int err; > Some compilers might have problems with this, maybe put it at the beginning > of the function and use […] well, I don't think we claim that this code works on non-gcc compilers only supporting the ancient C89 standard. So let's not debate about a hypothetical retrocomputing case :) -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: If9a83589b220ae7d937ef75c79de57be11858cd1 Gerrit-Change-Number: 28597 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: wbokslag <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Sun, 17 Jul 2022 08:09:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
