Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/4911/1/src/host/layer23/src/mobile/gsm411_sms.c
File src/host/layer23/src/mobile/gsm411_sms.c:

Line 299:            sms_mti, msg_ref,
I was dealing with this line.


Line 380:       rc = gsm340_rx_tpdu(trans, msg, rph->msg_ref);
> msg_ref is passed in as arg, gets logged above, and then this here is using
Well. This is why the next patch is killing msg_ref from the sms structure. But 
maybe it is better to sqaush them together?


-- 
To view, visit https://gerrit.osmocom.org/4911
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bac5f06921b5fd85a98d97770d42d4858ca1c42
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <[email protected]>
Gerrit-Reviewer: Holger Freyther <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-HasComments: Yes

Reply via email to