Attention is currently required from: fixeria.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/28724 )

Change subject: {ms,gprs_pcu}_talloc_destructor(): call osmo_timer_del() 
unconditionally
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1:
I personally like the fact of explicitly testing if timer is pending in order 
to show the reader that it may not necessarily be always armed, but fine anyway.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28724
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I062c7636b59714860fa6b49a2d59c6528ebd57e3
Gerrit-Change-Number: 28724
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 21 Jul 2022 22:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to